Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCCPPGHA-10 Rebrand and forward to the C and C++ action for SQS #64

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

antonioaversa
Copy link
Contributor

@antonioaversa antonioaversa commented Dec 5, 2024

SCCPPGHA-10

It rebrands the action, which now forwards to the C and C++ GHA for SQS.
It does not deprecate it yet though: we plan to deprecate both C and C++ GHA for SQS (sonarqube-github-c-cpp) and SQC (sonarcloud-github-c-cpp) at the same time, once the C and C++ GHA for SQS will forward to the general GHA for SQS (sonarqube-scan-action).
Otherwise, people would move to C and C++ GHA for SQS Github(sonarqube-github-c-cpp), to just receive another deprecation warning a week or two later 🙂

Successful runs (against 5fdf7f7 = current master~1):

List of checkpoint to verify/do before merging a PR.

Dev checklist

  • Write/update tests
  • Functional validation
  • Public documentation update
  • Private documentation update
  • Clean commits (should start with a ticket number, clear message, no fixup, wip)
  • Maximize code coverage as much as possible

Reviewer checklist

  • Code review
  • Functional validation
  • Check commits are clean

Steps to validate this PR

Fill-in how you performed the validation, and how the reviewer can replicate it:

  • [ ]

@antonioaversa antonioaversa force-pushed the antonio/SCCPPGHA-10-rebranding-forwarding branch 3 times, most recently from a66bc6c to c49eabb Compare December 6, 2024 10:53
@antonioaversa antonioaversa force-pushed the antonio/SCCPPGHA-10-rebranding-forwarding branch from c49eabb to 0cddea4 Compare December 6, 2024 13:47
@antonioaversa antonioaversa changed the title SCCPPGHA-10 Rebrand and replace Docker by composite action forwarding to the SQS C/C++ action SCCPPGHA-10 Rebrand and forward to the SQS C and C++ action Dec 6, 2024
@antonioaversa antonioaversa marked this pull request as ready for review December 6, 2024 13:58
@antonioaversa antonioaversa requested a review from a team as a code owner December 6, 2024 13:58
@antonioaversa antonioaversa changed the title SCCPPGHA-10 Rebrand and forward to the SQS C and C++ action SCCPPGHA-10 Rebrand and forward to the C and C++ action for SQS Dec 6, 2024
Copy link
Member

@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonioaversa antonioaversa merged commit 166e6d6 into main Dec 12, 2024
14 checks passed
@antonioaversa antonioaversa deleted the antonio/SCCPPGHA-10-rebranding-forwarding branch December 12, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants