Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing vs log #194

Closed
joshka opened this issue Jun 21, 2024 · 0 comments · Fixed by #195
Closed

tracing vs log #194

joshka opened this issue Jun 21, 2024 · 0 comments · Fixed by #195

Comments

@joshka
Copy link
Contributor

joshka commented Jun 21, 2024

I noticed when reading the code, there's a lot of log::trace!("[calloop] some message) calls.
I wonder if you'd be ok with moving the lib to just use tracing (with a few small changes for structured values being reported).

Some things of note:

  • tracing is a dependency of the polling crate, so it will be in the dependency tree already
  • tracing is a dependency of the biggest dependant of calloop by downloads (winit)
  • Tracing brings in proc-macro2 and syn. I saw you removed thiserror recently with the aim to remove these crates, but these are deps of the polling crate also (due to tracing).
  • tracing can write to log if needed.

PR incoming that aligns with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant