Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getVirtualSelect method to rework #756

Closed
romainruaud opened this issue Feb 15, 2018 · 1 comment
Closed

getVirtualSelect method to rework #756

romainruaud opened this issue Feb 15, 2018 · 1 comment
Assignees
Labels

Comments

@romainruaud
Copy link
Collaborator

romainruaud commented Feb 15, 2018

As we seen together, there is a problem with getVirtualSelect in Category Datasource.

The actual version is too wide and is catching event non-virtual categories, which produces doublons like this (where category 12 is not virtual) :

This seems to occur only when positions have been fixed to some products on a non-virtual category.

"category": [
            {
              "category_id": 2
            },
            {
              "category_id": 11,
              "name": "Men"
            },
            {
              "category_id": 12,
              "position": 1,
              "name": "Tops"
            },
            {
              "category_id": 14,
              "is_parent": true,
              "name": "Jackets"
            },
            {
              "category_id": 12,
              "is_virtual": "1",
              "position": 1,
              "name": "Tops"
            }
          ]
@afoucret
Copy link
Contributor

Fixed in branch 2.5.x and master.
You can test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants