Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag & Drop > Alignment problem #750

Closed
ghost opened this issue Feb 13, 2018 · 8 comments
Closed

Drag & Drop > Alignment problem #750

ghost opened this issue Feb 13, 2018 · 8 comments
Labels

Comments

@ghost
Copy link

ghost commented Feb 13, 2018

capture d ecran 2018-02-13 a 18 00 35

When I play with the drag & drop, the width of the product decreases and the layout is broken : a product from the 2nd line is moving to the 1st line. See screenshot enclosed.

Preconditions

I'm using Chrome 63 for Mac OS X

Magento Version : 2.2.0 Open source

ElasticSuite Version : Latest (2.5)

Steps to reproduce

Open the search terms, click the "merchandiser" button
Drag & drop several product.
After a few drag & drop the width of the products decreases.
Depending on the width of the browser, a product of the 2nd line may move to the 1st line.

@ghost
Copy link
Author

ghost commented Feb 13, 2018

Another problem with the drag & drop: it's very easy to move a product towards the left, but it's much more difficult to move a product towards the right.

@afoucret afoucret added the bug label Feb 14, 2018
@afoucret
Copy link
Contributor

Main problem confirmed.
After one hour spent debugging still no idea of how this can happen.

At the same time I had a try to improve a little bit the sorter with :

  • More compact design (make easier to move the items)
  • Better placeholder during while moving the product

Here is a screenshot :

capture d ecran 2018-02-14 a 10 38 01

What do you think about this ?

I will try to dig to find out why this small offset appears after we move items.

@romainruaud
Copy link
Collaborator

Haha @afoucret while working on the blacklist feature UX, I ended up to exactly the same design : moving the product name inside the "black box" to gain some space on top (I plan to have the "eye" button on top right).

Please let me know if you merge this on master so we are not conflicting

@djenvert
Copy link

Happy Valentine's Day, @afoucret and @romainruaud!

@afoucret
Copy link
Contributor

I will merge on 2.5.x and master today.
Wait for it.

@ghost
Copy link
Author

ghost commented Feb 14, 2018

It looks good ^^
About the small offset, when I look at the li object I see that the width doesn't change but the offsetLeft property is set to a wrong value: 587 instead of 591.
capture d ecran 2018-02-14 a 10 48 29

@afoucret
Copy link
Contributor

Fixed by PR #753
Will be part of the next maintenance release (2.5.2)

@afoucret
Copy link
Contributor

Merged in 2.5.x and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants