Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price range does not change on currency change #696

Closed
prateekkarki opened this issue Jan 18, 2018 · 5 comments · Fixed by #715
Closed

Price range does not change on currency change #696

prateekkarki opened this issue Jan 18, 2018 · 5 comments · Fixed by #715
Assignees

Comments

@prateekkarki
Copy link

Preconditions

Magento Version : 2.2 CE

ElasticSuite Version : 2.4

Environment : PHP 7.1 nginx on ubuntu

Steps to reproduce

  1. Set up a few different currencies from magento backend
  2. Check any page with price filter with slider
  3. Set a price range and hit OK to apply the filter
  4. Change the currency of the store

Expected result

  1. The price ranges should change according to the new currency
  2. If the price range is set for USD $10 to USD $100, upon change in the currency, the range should change to 1107.4 JPY to 11074 JPY, but it just stays on 10 JPY to 100 JPY

Actual result

  1. The values for price range should change according to the new currency
  2. If the price range is set for USD $10 to USD $100, upon change in the currency, the range just stays on 10 JPY to 100 JPY
@afoucret
Copy link
Contributor

Hi @prateekkarki,

We don't support multiple currencies. One quick workaround would be to disable price facet if using a currency that is different of the store view default currency.
@romainruaud : can you patch it against 2.4.x branch ?

It is far from being perfect but at least it will allow to not display a wrong information.

We should be able to have multiple currencies support in a later version (2.5.x or 2.6.x).

BR,

@afoucret afoucret modified the milestone: 2.5 Jan 19, 2018
@prateekkarki
Copy link
Author

Hi @afoucret ,

Thanks for adding it to 2.4.5, I will disable the facet for now and will be waiting for the update.

Meanwhile, if I can be of any help regarding the issue. Please feel free to tell me. With some explanation regarding the flow of price filter through the module, I'd be happy to contribute.

@afoucret
Copy link
Contributor

@romainruaud : ping

@doanhchuong
Copy link

doanhchuong commented Jun 6, 2018

hi @prateekkarki and @afoucret how to disable the price facet in code?
please help me . thanks

@prateekkarki
Copy link
Author

@doanhchuong Sorry for late response. You don't need to do that in code, you can do that through admin panel in magento. Just open the admin panel and go to :
Stores>Attributes>Product
and look for the price attribute. Edit the price attribute, inside the edit page you'll find 'Storefront Properties' and set 'Use in Search Results Layered Navigation' and 'Use in Layered Navigation' to No. and that should do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants