Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing category to virtual not triggers reindex #465

Closed
Koc opened this issue Jul 5, 2017 · 3 comments
Closed

Changing category to virtual not triggers reindex #465

Koc opened this issue Jul 5, 2017 · 3 comments

Comments

@Koc
Copy link
Contributor

Koc commented Jul 5, 2017

Preconditions

Magento Version : 2.1.7

ElasticSuite Version : 2.3.6

Environment : PHP 7.0.x

Third party modules :

Steps to reproduce

  1. Change some category to virtual
  2. Apply some rules

Expected result

  1. Some indexes marked as required reindex and will update by cron

Actual result

  1. no updates, all indexes are green, should run reindex manually by cli

not sure, maybe happens not only on mode switching but also when rules changed.

@romainruaud
Copy link
Collaborator

Hello,

I will check this one.

For me :

  • when switching a category from "standard mode" to "virtual category" : we should invalidate the index, to ensure products previously assigned to this category are correctly set out of the category.

  • when creating a virtual category, or changing a previous rule : there is no need to invalidate the index, since nothing is indexed for virtual categories : The query is processed in real time when navigating to the category page, which allow the category to evolve by itself when products matching the rule are changing (Eg. a category set to "Sale : Yes" will automatically display products that have just been set as "Sale : Yes").

Regards

@Koc
Copy link
Contributor Author

Koc commented Jul 5, 2017

Agreed with both. Thanx for fast response

@romainruaud
Copy link
Collaborator

PR merged.

Please use 2.3.x branch or wait for the next minor release.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants