Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined sessionConfig #457

Closed
gewaechshaus opened this issue Jun 21, 2017 · 3 comments
Closed

Undefined sessionConfig #457

gewaechshaus opened this issue Jun 21, 2017 · 3 comments
Assignees
Labels

Comments

@gewaechshaus
Copy link

gewaechshaus commented Jun 21, 2017

With minification, bundling and grouping enabled in we are experience a JS frontend error within the SmileTrackerImpl.

Preconditions

MCE2.1.7
ES 2.3
Haproxy:80->Varnish->Nginx->PHP-FPM7 on Ubuntu 16.04

Tracking is disabled by admin

Issue

Uncaught TypeError: Cannot read property 'sessionConfig' of undefined
at SmileTrackerImpl.initSession (87824f0….min.js:213)
at SmileTrackerImpl.getTrackerUrl (87824f0….min.js:204)
at SmileTrackerImpl.sendTag (87824f0….min.js:208)

initSession @ 87824f0….min.js:213
getTrackerUrl @ 87824f0….min.js:204
sendTag @ 87824f0….min.js:208

It looks like the JS does get included even if the tracking is disabled, this results in empty cookie/ no session.

Called at
https://github.com/Smile-SA/elasticsuite/blob/master/src/module-elasticsuite-tracker/view/frontend/web/js/tracking.js#L182

Browse our frontend on https://www.makerdise.com/ with developer console enabled.

Regards
Jan

@romainruaud
Copy link
Collaborator

Confirmed.

Fix is in the PR #460

@gewaechshaus
Copy link
Author

THX @romainruaud

@afoucret
Copy link
Contributor

PR have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants