Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong validation example. #73

Open
skerkewitz opened this issue Oct 20, 2016 · 2 comments
Open

Wrong validation example. #73

skerkewitz opened this issue Oct 20, 2016 · 2 comments

Comments

@skerkewitz
Copy link
Contributor

skerkewitz commented Oct 20, 2016

Hello,

are you guys aware that the validation example you show under Error state and delegates has little flaw? You validate the text of the textfield before the actual text change and not after the text change. So basically your validation is always one char behind what actual going on in the textfield.

Anyways, keep up the good work!
Stefan

@k0nserv
Copy link
Contributor

k0nserv commented Nov 29, 2016

I'll have a look at this at some point, but if you wanna send a PR after we merge the Swift 3 branch in #67 that'd be awesome

@Franknxtn
Copy link

I Have a Problem as well with validation. In my case i have put a validation in one of my skyFloatingLabelTextfield so that the entered text must be at least 5 character long. The Validation is Working fine as expected for the first time , but However, if i delete a character it is still showing the field as correct one. i'd like to immediately show error on this field as soon as the character is deleted. I'm doing the validation using the delegate method as shown in example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants