Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3.0 #55

Closed
enescakir opened this issue Jun 18, 2016 · 22 comments
Closed

Swift 3.0 #55

enescakir opened this issue Jun 18, 2016 · 22 comments

Comments

@enescakir
Copy link

Thanks for great library.
Are you planning to publish a swift3 branch? When I tried to build it in Swift 3, it gives 78 error.

@codytwinton
Copy link

Love you library! Can you please enable a swift3 branch we can create pull requests for.

@ossmalpha
Copy link

When it is planned to release the converted (to Swift 3) branch?

@rolmaz
Copy link

rolmaz commented Sep 16, 2016

Swift 3 branch?

@Tibb
Copy link

Tibb commented Sep 21, 2016

No activity on Github or any social network since July... Hope he's just on extended holidays :)

@wolffan
Copy link
Contributor

wolffan commented Sep 21, 2016

Hello all.
Apologies, it's not "exactly" holiday 😵. I'll dedicate some time this week and look at the swift 3 PR's.

@Tibb
Copy link

Tibb commented Sep 21, 2016

@wolffan Sorry about that, the latest commit was from gergelyorosz, who is the only profile I quickly checked.
Thanks a lot for your answer and good luck 👍

@kwstasna
Copy link

So what's going on with the swift 3 version!?! Hope to see it soon 👍

@codytwinton
Copy link

@wolffan - Is there anyway a swift3 branch could be created so we can make pull requests there?

@lfarah
Copy link

lfarah commented Oct 4, 2016

Hey, I'd love to see this lib available in Swift 3 so I can implement it in my project.

Thanks 😄

@Tibb
Copy link

Tibb commented Oct 5, 2016

@kwstasna @codytwinton @lfarah Until the DenHeadless pull request is accepted or until @wolffan develops his own, you can use it like this in your Podfile:

pod 'SkyFloatingLabelTextField', git: 'https://github.com/MLSDev/SkyFloatingLabelTextField.git', branch: 'swift3'

It compiles and seems to work great so far.

@lfarah
Copy link

lfarah commented Oct 5, 2016

Thanks @Tibb, you're awesome! 🎉

@wagnercasey
Copy link

@Tibb for real awesome! thanks! running great.

@Tibb
Copy link

Tibb commented Oct 5, 2016

Thx guys but all the credit goes to @DenHeadless who create the pull request. I'm just indicating how to integrate it in your project with CocoaPods ;)

@k0nserv
Copy link
Contributor

k0nserv commented Nov 29, 2016

Hey everyone, sorry this has taken such a long time. This project lost its maintainer when gergelyorosz left Skyscanner, but me and @wolffan are looking at releasing the Swift 3 version in the next few days. We are also likely to add someone from the community as a contributor to reduce dependency on the two of us.

@codytwinton
Copy link

@k0nserv - Thanks for making this happen!

@lfarah
Copy link

lfarah commented Nov 30, 2016

Hey @k0nserv, let's talk! I'd be more than happy to start contributing more and help you guys out

@k0nserv
Copy link
Contributor

k0nserv commented Nov 30, 2016

1.3.1 is out with Swift 2.3 support. Focus now is to get the changes in #67 released as 2.0

@nazrdogan
Copy link

+1

@smdulgeroglu
Copy link

+1 can't wait thanks a lot

@k0nserv
Copy link
Contributor

k0nserv commented Dec 7, 2016

#67 is merged now, if someone wants to point their pod version at master and check if that works well that'd be great. I'm preparing the 2.0 release

@k0nserv
Copy link
Contributor

k0nserv commented Dec 7, 2016

That's 2.0 released with Swift 3 support. Please raise any bugs as a new issue.

image

https://cocoapods.org/pods/SkyFloatingLabelTextField

@k0nserv k0nserv closed this as completed Dec 7, 2016
@lfarah
Copy link

lfarah commented Dec 7, 2016

@k0nserv you're awesome!!!!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests