Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extraneous [the] in hotbar slot expression. #6563

Closed
1 task done
Moderocky opened this issue Apr 14, 2024 · 0 comments
Closed
1 task done

Extraneous [the] in hotbar slot expression. #6563

Moderocky opened this issue Apr 14, 2024 · 0 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. good first issue An issue that would be good for a first-time contributor to make a PR for help wanted Contributions are highly welcomed PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@Moderocky
Copy link
Member

Skript/Server Version

N/A

Bug Description

ExprHotbarSlot is a property expression but includes a [the] in its pattern, so this gets duplicated twice (and put in the wrong place!): player's the hotbar slot, the the hotbar slot of player.

Presumably it originally wasn't a property expression and somebody forgot to change it.

image image

Expected Behavior

It probably shouldn't be there twice 😬

Steps to Reproduce

Open the file

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@Moderocky Moderocky added the good first issue An issue that would be good for a first-time contributor to make a PR for label Apr 14, 2024
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Apr 14, 2024
@Moderocky Moderocky added priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). help wanted Contributions are highly welcomed and removed bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. labels Apr 14, 2024
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Apr 14, 2024
@Phill310 Phill310 mentioned this issue Apr 15, 2024
Merged
@AyhamAl-Ali AyhamAl-Ali added the PR available Issues which have a yet-to-be merged PR resolving it label Apr 15, 2024
@Moderocky Moderocky added the completed The issue has been fully resolved and the change will be in the next Skript update. label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. good first issue An issue that would be good for a first-time contributor to make a PR for help wanted Contributions are highly welcomed PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sovdeeth @Moderocky @AyhamAl-Ali