Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compare clicked slot #4548

Closed
1 task done
Yahumoo opened this issue Jan 29, 2022 · 7 comments
Closed
1 task done

Can't compare clicked slot #4548

Yahumoo opened this issue Jan 29, 2022 · 7 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@Yahumoo
Copy link

Yahumoo commented Jan 29, 2022

Skript/Server Version

[02:35:40 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[02:35:40 INFO]: [Skript] Skript's documentation can be found here: https://skriptlang.github.io/Skript
[02:35:40 INFO]: [Skript] Server Version: git-Purpur-1537 (MC: 1.18.1)
[02:35:40 INFO]: [Skript] Skript Version: 2.6.1
[02:35:40 INFO]: [Skript] Installed Skript Addons:
[02:35:40 INFO]: [Skript]  - skript-yaml v1.4
[02:35:40 INFO]: [Skript]  - MorkazSk v1.2
[02:35:40 INFO]: [Skript]  - skUtilities v0.9.2 (https://tim740.github.io/)
[02:35:40 INFO]: [Skript]  - SkQuery v4.1.6
[02:35:40 INFO]: [Skript]  - SkBee v1.14.2 (https://github.com/ShaneBeee/SkBee)
[02:35:40 INFO]: [Skript] Installed dependencies: None

Bug Description

if clicked slot is between 0 and 8: doesn't work after I update skript
(but if clicked slot is 0: works)

Expected Behavior

condition pass

Steps to Reproduce

just update skript to 2.6.1

Errors or Screenshots

[02:33:18 ERROR]: [Skript] Line 244: (Seasonpass.sk)
    Can't compare a slot with ('between 0' and '8')
    Line: if clicked slot is between 0 and 8:

Other

No response

Agreement

  • I have read the guidelines above and confirm I am following them with this report.
@TPGamesNL TPGamesNL self-assigned this Jan 29, 2022
@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Jan 29, 2022
@TPGamesNL
Copy link
Member

While this is an issue, I don't think this ever worked (this error is on Skript 2.6):
image

@Yahumoo
Copy link
Author

Yahumoo commented Jan 29, 2022

I'm so sorry I was mistaken.. I mistook clicked slot for clicked raw slot(skellett expression)
Because skellett doesnt work on skript 2.6.1

@TPGamesNL
Copy link
Member

I'm so sorry I was mistaken.. I mistook clicked slot for clicked raw slot(skellett expression)

No problem :D

@NotSoDelayed
Copy link
Contributor

Skript itself has it:
if index of event-slot is between 0 and 8:

@TPGamesNL
Copy link
Member

Skript itself has it: if index of event-slot is between 0 and 8:

That doesn't mean the version mentioned before shouldn't work too

@TheLimeGlass
Copy link
Contributor

TheLimeGlass commented Jan 31, 2022

Skellett and Umbaska have always called clicked slot as an Integer. In Skript Slot represents the entire slot, including item details. We already had a debate about making clicked slot a number when it was added, but bensku made the clicked slot expression return the Slot admit others not agreeing with the change.

So now we have to use index of clicked slot

Can't Slot to Integer comparator fix this issue? That may have been done in the past and it broke scripts if I remember?

@TPGamesNL
Copy link
Member

Can't Slot to Integer comparator fix this issue?

Yes, that's what the PR fixing this does, it improves that comparator

@TPGamesNL TPGamesNL added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

5 participants