Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script[s] [%strings%] (is|are) loaded gives error #4467

Closed
1 task done
PersonMaster opened this issue Dec 17, 2021 · 3 comments
Closed
1 task done

script[s] [%strings%] (is|are) loaded gives error #4467

PersonMaster opened this issue Dec 17, 2021 · 3 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@PersonMaster
Copy link

Skript/Server Version

[Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[Skript] Skript's documentation can be found here: https://skriptlang.github.io/Skript
[Skript] Server Version: git-Paper-399 (MC: 1.17.1)
[Skript] Skript Version: 2.6
[Skript] Installed Skript Addons: 
[Skript]  - Skent v3.1.0
[Skript]  - skript-reflect v2.2.3 (https://github.com/TPGamesNL/skript-reflect)
[Skript]  - SkQuery v4.1.5
[Skript]  - SkBee v1.14.0 (https://github.com/ShaneBeee/SkBee)
[Skript]  - SkJade v1.3.4 (https://www.github.com/Ankoki-Dev/SkJade)
[Skript]  - Skript-Packet v2.0.1 (www.github.com/Anarchick/skript-packet)
[Skript] Installed dependencies: None

Bug Description

When you are using the script condition script[s] [%strings%] (is|are) loaded, you are instead faced with a console error.

Expected Behavior

Skript should instead check if the specified script is loaded/unloaded.

Steps to Reproduce

I used the effect !broadcast "&aTrue" if script "Test.sk" is loaded, but I have also tested it with scripts.

Errors or Screenshots

https://www.toptal.com/developers/hastebin/cequmafige.md

Other

No response

Agreement

  • I have read the guidelines above and confirm I am following them with this report.
@BaeFell
Copy link
Member

BaeFell commented Dec 17, 2021

What error log happens when you do it in a script?

@PersonMaster
Copy link
Author

Interestingly enough, there is no console error.

@AyhamAl-Ali
Copy link
Member

Line 61: Shouldn't be hard to fix, just handle it in effect commands since getParser#getCurrentScript() is marked as Nullable

@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Dec 19, 2021
@TPGamesNL TPGamesNL added the PR available Issues which have a yet-to-be merged PR resolving it label Dec 26, 2021
@TPGamesNL TPGamesNL added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

5 participants