Flat file storage race condition

[SaFiKiK]

Skript/Server Version

[Sun, 31. Oct 2021 15:18:40 GMT INFO] [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[Sun, 31. Oct 2021 15:18:40 GMT INFO] [Skript] Skript's documentation can be found here: https://skriptlang.github.io/Skript
[Sun, 31. Oct 2021 15:18:40 GMT INFO] [Skript] Server Version: git-Paper-338 (MC: 1.17.1)
[Sun, 31. Oct 2021 15:18:40 GMT INFO] [Skript] Skript Version: 2.6
[Sun, 31. Oct 2021 15:18:40 GMT INFO] [Skript] Installed Skript Addons:
[Sun, 31. Oct 2021 15:18:40 GMT INFO] [Skript]  - SkUniversal v2.12.5
[Sun, 31. Oct 2021 15:18:40 GMT INFO] [Skript]  - Skellett v1.9.11 (https://forums.skunity.com/resources/skellett.24/)
[Sun, 31. Oct 2021 15:18:40 GMT INFO] [Skript]  - skript-gui v1.3-alpha3 (https://github.com/APickledWalrus/skript-gui)
[Sun, 31. Oct 2021 15:18:40 GMT INFO] [Skript]  - SkQuery v4.1.5
[Sun, 31. Oct 2021 15:18:40 GMT INFO] [Skript]  - SkBee v1.11.4 (https://github.com/ShaneBeee/SkBee)
[Sun, 31. Oct 2021 15:18:40 GMT INFO] [Skript]  - skript-holo v1.0.2 (https://github.com/Blueyescat/skript-holo)

Bug Description

Creating multiple Flat File databases leads to race condition when they try to save variables. When there are thousands (or even millions) of variables to save, for different databases, multiple threads try to access the same file called variables.csv.temp. This leads to random data being saved into different databases. While the server is online, all Flat Storage Files will have random data from the other databases. After the server shutdown, all data in files become normal. This also produces errors in console (pasted further in report).

Expected Behavior

Each Flat File Storage creates its own temp variables file and uses this file to write variables to the database.

Probably, just change "variables.csv.temp" to name + ".csv.temp"?

Steps to Reproduce

1. Create multiple Flat File Databases in Skript config
2. Start the server, run any function which will save a lot of variables to different databases
3. Wait for saveTask to run.

Errors or Screenshots

[12:14:06 UTC ERROR] [Skript] Unable to make a final save of the database 'default' (no variables are lost): plugins/Skript/variables.csv.temp -> /home/minecraft/server/./plugins/Skript/variables.csv
[12:14:06 UTC ERROR] [Skript] Unable to make a final save of the database 'blockdata' (no variables are lost): plugins/Skript/variables.csv.temp -> /home/minecraft/server/./plugins/Skript/Data/BlockData.csv
[12:14:06 UTC ERROR] [Skript] Unable to make a final save of the database 'ranks' (no variables are lost): plugins/Skript/variables.csv.temp -> /home/minecraft/server/./plugins/Skript/Data/Ranks.csv
[12:14:06 UTC ERROR] [Skript] Unable to make a final save of the database 'itemdata' (no variables are lost): plugins/Skript/variables.csv.temp -> /home/minecraft/server/./plugins/Skript/Data/ItemData.csv

Other

No response

Agreement

• I have read the guidelines above and confirm I am following them with this report.