Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported 'event-item frame' in break event #4359

Closed
1 task done
vhone opened this issue Oct 11, 2021 · 1 comment
Closed
1 task done

Unsupported 'event-item frame' in break event #4359

vhone opened this issue Oct 11, 2021 · 1 comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@vhone
Copy link

vhone commented Oct 11, 2021

Skript/Server Version

[Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[Skript] Skript's documentation can be found here: https://skriptlang.github.io/Skript
[Skript] Server Version: git-Paper-127 (MC: 1.17.1)
[Skript] Skript Version: 2.6-beta3-nightly-4c9a3ab
[Skript] Installed Skript Addons:
[Skript] - skript-reflect v2.2.2-dev (https://github.com/TPGamesNL/skript-reflect)

Bug Description

This is a small issue.

With event-item frame expression, item frame entity can be received in on place, but not in on break.

The getEntity() method of HangingBreakByEntityEvent returns an item frame entity. I wish I could use this

Expected Behavior

Like on place event, event-item frame should be available for on break event as well.

Steps to Reproduce

on place of item frame:
    send "[place] %event-player%" to console
    send "[place] %event-entity%" to console
    send "[place] %event-item frame%" to console

on break of item frame:
    send "[break] %event-player%" to console
    send "[break] %event-entity%" to console
    send "[break] %event-item frame%" to console

result

[place] vhone
[place] vhone
[place] item frame
[break] vhone
[break] vhone
[break] <none>

Errors or Screenshots

Replace this text with your paste link or errors/screenshots/videos.

Other

No response

Agreement

  • I have read the guidelines above and confirm I am following them with this report.
@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Oct 11, 2021

There is nothing called event-item frame there is event-item but not in the break event.
Break event has event-block which should solve your issue

You can also do event-entity in break event to get the remover of the hanging entity

Hanging event do have an event value for getEntity but it's probably overwritten by the getRemover in the hanging break event
check this line and this line

An expression can be added to get the hanging entity

@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Oct 17, 2021
@TPGamesNL TPGamesNL added the PR available Issues which have a yet-to-be merged PR resolving it label Feb 12, 2022
@TPGamesNL TPGamesNL added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

4 participants