Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block handling below Y 0 (1.18) #4324

Closed
1 task done
Craftifyeu opened this issue Sep 8, 2021 · 12 comments
Closed
1 task done

Block handling below Y 0 (1.18) #4324

Craftifyeu opened this issue Sep 8, 2021 · 12 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@Craftifyeu
Copy link

Skript/Server Version

Server Version: git-Tuinity-"4c31ea1" (MC: 1.17.1)
Skript Version: 2.6-beta2

Installed Skript Addons:
Skellett v1.9.11
skript-yaml v1.3.2
CreatioLib v0.1.02-alpha
skRayFall v1.9.25
Ticker v1.0.0
SharpSK v1.6.4
SkUniversal v2.12.5
DiSky v2.1
skDragon v0.17
skript-reflect v2.2.3
skript-db v0.2.0
Reqn v1.2.1
SkQuery v4.1.4
SkriptJSON v1.0.0
Ersatz v1.0
RandomSK v2.7.1
WolvSK v1.7.2
SkStuff v1.6.4.1

Bug Description

Loop-block works above Y location 0 but when I go lower and I want the loop-block to destroy it, nothing happens, it can't detect both players and blocks below location zero

Expected Behavior

Not working under location 0 (C&C datapack)

Steps to Reproduce

bug description

Errors or Screenshots

YouTube video https://youtu.be/P6m9dk8XkX8

Other

No response

Agreement

  • I have read the guidelines above and confirm I am following them with this report.
@Craftifyeu
Copy link
Author

sorry for my english (i'am using translator, i'am from the Czech Republic) :D

@bluelhf
Copy link
Contributor

bluelhf commented Sep 8, 2021

Sounds like Spigot being unprepared for 1.18. I don't think Skript can do much here

@Craftifyeu
Copy link
Author

Craftifyeu commented Sep 8, 2021

I don't know why, but it seems to me more like a skunity than a spigot. Why would other plugins work under location 0 and the script would not?

@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Sep 8, 2021

Not sure if this is what you mean but I can't replicate this

on chat:
	#broadcast "%blocks below player%"
	loop blocks below player:
		send "%loop-block%"
		break loop-block naturally

image
image

No addons in my server, skript 2.6-beta1 and paper 1.16.5
Try this without any of your addons

UPDATE: Tested with paper 1.17 and skript 2.6-beta3 still works as expected

UPDATE: I can confirm I can't place blocks below y=0 in 1.17 not by hand nor by skript

@Craftifyeu
Copy link
Author

When I update to beta 3, 80% of my scripts stopped working.

@AyhamAl-Ali
Copy link
Member

When I update to beta 3, 80% of my scripts stopped working.

There were little breaking changes in 2.6 such as singular quotes instead of double quotes in strings and addons patches probably only those, if you have any script errors you can simply post them in SkUnity discord help channels

@TPGamesNL
Copy link
Member

When I update to beta 3, 80% of my scripts stopped working.

@Craftifyeu Do you get any errors (when reloading or in console)? Can you show a simple script that stopped working?

@TPGamesNL
Copy link
Member

As 1.18 may have blocks below y=0, Skript should be updated to allow this

lowerBound = new Vector(center.getX() - rX, Math.max(center.getY() - rY, 0), center.getZ() - rZ);

@Craftifyeu I'm just curious: how do you have blocks at Y -1 in Minecraft 1.17?

@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Sep 9, 2021
@TPGamesNL TPGamesNL changed the title C&C loop blocks Block handling below Y 0 (1.18) Sep 9, 2021
@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. and removed enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Sep 9, 2021
@Craftifyeu
Copy link
Author

1.17

Datapack C&C

@Craftifyeu
Copy link
Author

Craftifyeu commented Sep 10, 2021

As 1.18 may have blocks below y=0, Skript should be updated to allow this

lowerBound = new Vector(center.getX() - rX, Math.max(center.getY() - rY, 0), center.getZ() - rZ);

@Craftifyeu I'm just curious: how do you have blocks at Y -1 in Minecraft 1.17?

and it will be added before 1.18 or must wait for 1.18

@Craftifyeu
Copy link
Author

When I update to beta 3, 80% of my scripts stopped working.

@Craftifyeu Do you get any errors (when reloading or in console)? Can you show a simple script that stopped working?

i rewrote my whole code, now my code's working in latest update.

@TPGamesNL
Copy link
Member

and it will be added before 1.18 or must wait for 1.18

I don't know, but it's an easy fix so it'll probably be fixed before 1.18 (although I don't know when 1.18 comes out)

@TPGamesNL TPGamesNL added PR available Issues which have a yet-to-be merged PR resolving it completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

5 participants