Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do If Issue #3983

Closed
Th-Underscore opened this issue May 10, 2021 · 1 comment
Closed

Do If Issue #3983

Th-Underscore opened this issue May 10, 2021 · 1 comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@Th-Underscore
Copy link

Description

Using do if with stop loop fully stops the trigger, rather than just stopping the loop. Using an if statement makes it work fine.

Steps to Reproduce

Not sure how to format instructions, so I'll just send one of the snippets I tried debugging this.
1 (doesn't work):

on script load:
    loop 9 times:
        broadcast "%loop-value%"
        stop loop if loop-value is 5
    broadcast "we did it!"

2 (works):

on script load:
    loop 9 times:
        broadcast "%loop-value%"
        if loop-value is 5:
            stop loop
    broadcast "we did it!"

Expected Behavior

It should broadcast 1 to 5 in chat, then we did it!, but it only broadcasts 1 to 5.

Errors / Screenshots

1: image

2: image

Server Information

  • Server version/platform: Paper 1.16.5
  • Skript version: 2.5.3
@AyhamAl-Ali
Copy link
Member

I remember once I was trying do if statement and it stopped the whole trigger instead of skipping the single effect line, but that was sometime ago and I stopped using the do if statement however I love it but I forgot about it after that, so this might be related but not sure.

@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels May 11, 2021
@TPGamesNL TPGamesNL added the PR available Issues which have a yet-to-be merged PR resolving it label May 11, 2021
@APickledWalrus APickledWalrus added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

5 participants