Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity between on step and on stepping events #2555

Closed
MaPaJe opened this issue Oct 11, 2019 · 14 comments
Closed

Ambiguity between on step and on stepping events #2555

MaPaJe opened this issue Oct 11, 2019 · 14 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@MaPaJe
Copy link

MaPaJe commented Oct 11, 2019

Description

The on stop on pressureplate event is only triggered upon jumping on it.
Skript version 2.4 beta-7
Paper 1.12.2

This for some reason wasn't a problem in 2.4Beta-5

Tested Versions:
2.4 Beta-8: Problematic
2.4 Beta-7: Problematic
2.4 Beta-6: Problematic
2.4 Beta-5: Working as expected
2.4 Alpha-4: Problematic
2.3.7: Problematic
2.3.6: Problematic
2.3.5: Working as expected
2.3.3: Problematic
2.3.2: Working as expected
2.3.1: Working as expected
2.2 Dev36 Working as expected

Steps to Reproduce

on step on pressure plate:
broadcast "%event-block%"
broadcast "&6Congratz you stepped on me"

stepping on it / jumping on it

Expected Behavior

Triggers upon any move on a pressureplate like in 2.4 Beta 5

Errors / Screenshots

https://gyazo.com/1dbffaea66d521bec10abbc85f4f9a7f

@ShaneBeee
Copy link
Contributor

Skript version 2.4 beta-7

Since we only accept bug reports for the latest version available, could you please test this on version 2.4-beta8 and report back your findings.

@ShaneBeee ShaneBeee added the needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. label Oct 12, 2019
@MaPaJe
Copy link
Author

MaPaJe commented Oct 12, 2019

I've tested on multiple versions now.

@TPGamesNL
Copy link
Member

You shouldn't use this event, it's not meant for pressure plates. Use this instead.

@MaPaJe
Copy link
Author

MaPaJe commented Oct 12, 2019

It's the event Im using, Look at the syntax @TPGamesNL

@TPGamesNL
Copy link
Member

It's the event Im using, Look at the syntax @TPGamesNL

Sorry, I didn't notice since they have like the exact same syntax, which might be the issue. Can you check if on plate: works?

@ShaneBeee
Copy link
Contributor

I've tried this on both Paper 1.12.2 and Paper 1.14.4, both using Skript 2.4-beta8, and I could not replicate the issue.
Every time I walk onto a pressure plate, it fires the event.

Are you possibly using any addons which may be causing conflicts?
Try replicate this issue without any addons on your server.

@MaPaJe
Copy link
Author

MaPaJe commented Oct 12, 2019

No addons just a regular stone pressure plate

@bluelhf
Copy link
Contributor

bluelhf commented Oct 12, 2019

I remember there being an issue where you wouldn't trigger the step event for the plate, but for thd block below it, since you aren't really stepping on the plate itself.

@MaPaJe
Copy link
Author

MaPaJe commented Oct 12, 2019

If you go from a carpet onto the pressure plate, the event will always be fired

@MaPaJe
Copy link
Author

MaPaJe commented Oct 12, 2019

Using On Plate: yields a consistant outcome
Why the event is triggered differntly between versions, still bothers me

@MaPaJe MaPaJe closed this as completed Oct 12, 2019
@MaPaJe MaPaJe reopened this Oct 12, 2019
@MaPaJe
Copy link
Author

MaPaJe commented Oct 12, 2019

I think on step on pressure plate: should trigger on plate,
its because its conflicting with the on step event

@ShaneBeee
Copy link
Contributor

ShaneBeee commented Oct 12, 2019

so what I noticed is as follows:

on step on pressure plate:

this triggers the "step on" event, the reason this doesnt fire is because you arent stepping on the pressure plate block, since you are already technically on it, you are stepping on the block below it.

on stepping on pressure plate:

this fires the pressure plate event, which fires consistently when you walk/jump on it.

@bensku
Copy link
Member

bensku commented Oct 13, 2019

That seems confusing. We need to update syntaxes.

@bensku bensku added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. and removed needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. labels Oct 13, 2019
@Whimsyturtle Whimsyturtle changed the title on step on pressureplate Ambiguity between on step and on stepping events Oct 17, 2019
@TheLimeGlass
Copy link
Contributor

TheLimeGlass commented Jul 13, 2020

This has been broken since around 1.10. I don't know if it still does this but; if you cancelled the event it would send you through the block. Here is a video I posted about it back in 2016 https://www.youtube.com/watch?v=V_rUiqICfvA

I also think there is another issue thread about this already.

@TPGamesNL TPGamesNL added the PR available Issues which have a yet-to-be merged PR resolving it label Aug 11, 2021
@TPGamesNL TPGamesNL added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

7 participants