Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a histogram #3

Open
tcolgate opened this issue Sep 21, 2016 · 1 comment
Open

Use a histogram #3

tcolgate opened this issue Sep 21, 2016 · 1 comment
Labels
enhancement help wanted

Comments

@tcolgate
Copy link
Collaborator

A histogram would probably be a better fit for the gc stats, we could follow the Go client library

go_gc_duration_seconds_count
go_gc_duration_seconds_sum
go_gc_duration_seconds

They use a summary, but I think a couple of histograms for

nodejs_gc_duration_seconds
nodejs_gc_reclaim_bytes

might be good

thoughts?
@SimenB
Copy link
Owner

SimenB commented Sep 21, 2016

Yeah, that makes sense! Care to open a PR for it?

@zbjornson zbjornson mentioned this issue Dec 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tcolgate @SimenB