Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme replace removes customer templates #102

Closed
cshold opened this issue Oct 1, 2015 · 5 comments
Closed

theme replace removes customer templates #102

cshold opened this issue Oct 1, 2015 · 5 comments
Labels

Comments

@cshold
Copy link
Contributor

cshold commented Oct 1, 2015

Customer templates are removed and never added/updated. theme upload templates/customers* works as expected.

Venture (venture-featured-items) >> theme replace
Successfully performed Update operation for file layout/theme.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file snippets/product-card.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file snippets/social-sharing.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file snippets/svg-definitions.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Remove operation for file templates/customers/account.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file assets/icons.json to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file assets/shop.js.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/index.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/article.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file assets/icons.svg to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file locales/en.default.json to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file snippets/featured-products.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file assets/icons.woff to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file locales/de.json to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/password.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file config/settings_schema.json to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file locales/pt-PT.json to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file snippets/comment.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/blog.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/page.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file assets/ico-select.svg.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file assets/icons.eot to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file assets/shop.scss.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Remove operation for file templates/customers/register.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file assets/icons.ttf to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file assets/modernizr.min.js to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file locales/fr.json to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/cart.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Remove operation for file templates/customers/login.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/page.contact.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Remove operation for file templates/customers/order.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Remove operation for file templates/customers/reset_password.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/list-collections.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file assets/gift-card.scss.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/404.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/collection.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file snippets/meganav.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Remove operation for file templates/customers/activate_account.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Remove operation for file templates/customers/addresses.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/gift-card.liquid to venture-theme-snowboards.myshopify.com
[403]Cannot remove files that would make a theme invalid. templates/gift_card.liquid
Successfully performed Update operation for file config/settings_data.json to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file locales/es.json to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file locales/pt-BR.json to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/product.liquid to venture-theme-snowboards.myshopify.com
Successfully performed Update operation for file templates/search.liquid to venture-theme-snowboards.myshopify.com
@cshold cshold added the 🐛 bug label Oct 1, 2015
@csaunders csaunders added this to the Application Stability milestone Oct 1, 2015
@csaunders csaunders self-assigned this Oct 1, 2015
@cshold
Copy link
Contributor Author

cshold commented Nov 25, 2015

Still valid on v0.3.2

@ilikeorangutans
Copy link
Contributor

Is templates the only directory that has a child directory?

@cshold
Copy link
Contributor Author

cshold commented Jan 7, 2016

Yes it is

@ilikeorangutans
Copy link
Contributor

Ok, after spending a good hour writing detailed tests for the replace command and finding nothing, I finally realized that the issue is elsewhere! Turns out ThemeClient.LocalAssets() uses a double star glob **/* to find files, but that is currently unsupported in go.

With that in mind I can finally come up with a solution for this!

@stevebosworth
Copy link
Contributor

Works for me!!
ship pit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants