Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce global suggestions for supporting {% # theme-check-disable <type> %} #113

Open
karreiro opened this issue Sep 27, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@karreiro
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, our language server doesn't offer suggestions to ignore theme-check offenses. I believe it would be a great to have a single implementation to ignore across all checks (something like: {% # theme-check-disable <check_name> %}).

I don't foresee this feature promoting excessive use of the ignore function. Given that comments in the code already create a certain level of noise, so this feature seems to be more beneficial than not providing those suggestions.

@charlespwd
Copy link
Contributor

I believe we already do support theme-check-disable 🤔 ?

@karreiro
Copy link
Contributor Author

karreiro commented Oct 6, 2023

We do support theme-check-disable, but I'm proposing we add the theme-check-disable suggestion for all offenses. Wdyt?

@charlespwd
Copy link
Contributor

charlespwd commented Oct 6, 2023

Ahhhhh my bad I totally misunderstood the nuance. à la ESLint, I love this. Great suggestion! :D

@mgmanzella mgmanzella added the enhancement New feature or request label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants