Add comments highlighting code duplication in parameter removal logic

Author: jamesmengo

packages/theme-check-common/src/checks/duplicate-render-snippet-params/index.ts

@@ -40,6 +40,9 @@ export const DuplicateRenderSnippetParams: LiquidCheckDefinition = {
                 {
                   message: `Remove duplicate parameter '${paramName}'`,
                   fix: (fixer) => {
+                    // This parameter removal logic is duplicated in UnrecognizedRenderSnippetParams
+                    // Consider extracting to a shared utility or simplifying the removal approach in the parsing steps.
+                    // I chose not to do so here as I would like more examples to see how this should be done.
                     const sourceBeforeArg = node.source.slice(0, param.position.start);
                     const matches = sourceBeforeArg.match(/,\s*/g);
                     const lastWhitespaceMatch = matches ? matches[matches.length - 1] : null;

packages/theme-check-common/src/checks/unrecognized-render-snippet-params/index.ts

@@ -36,7 +36,9 @@ export const UnrecognizedRenderSnippetParams: LiquidCheckDefinition = {
             {
               message: `Remove '${param.name}'`,
               fix: (fixer) => {
-                // This is a bit messy, but it allows us to strip leading and trailing whitespaces and commas
+                // This parameter removal logic is duplicated in DuplicateRenderSnippetParams
+                // Consider extracting to a shared utility or simplifying the removal approach in the parsing steps.
+                // I chose not to do so here as I would like more examples to see how this should be done.
                 const sourceBeforeArg = node.source.slice(0, param.position.start);
                 const matches = sourceBeforeArg.match(/,\s*/g);
                 const lastWhitespaceMatch = matches ? matches[matches.length - 1] : null;