Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Change src/assets/vendors to src/assets/static #411

Closed
t-kelly opened this issue Feb 23, 2018 · 2 comments
Closed

Change src/assets/vendors to src/assets/static #411

t-kelly opened this issue Feb 23, 2018 · 2 comments
Labels

Comments

@t-kelly
Copy link
Contributor

t-kelly commented Feb 23, 2018

Problem

Currently, src/assets/vendors is the only folder that has its contents copied directly to the dist/assets folder, e.g. src/assets/vendors/modernizr.js gets copied to dist/assets/modernizr.js.

All other files and folders in the src/assets/ folder need to be referenced from an entry point, e.g. theme.js.

The current name vendors implies, at least to myself, that it is for vendor JS (e.g. jQuery, or Modernizr), where in fact it is for any file you want always copied into your dist/assets folder.

I propose that we rename the vendor folder to static to make this a little more clear.

@jlyon
Copy link

jlyon commented Mar 1, 2018

+1

@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants