Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Currency converter reverts to default using Slate #322

Closed
e-dolan opened this issue Oct 14, 2017 · 4 comments
Closed

Currency converter reverts to default using Slate #322

e-dolan opened this issue Oct 14, 2017 · 4 comments
Labels

Comments

@e-dolan
Copy link

e-dolan commented Oct 14, 2017

Problem

Following the below tutorial to add a currency converter and it does not work with Slate or sectioned themes. Shopify say they will update the documentation but a fix is needed.

https://help.shopify.com/themes/customization/currencies/show-multiple-currencies

When the code is added, the converter converts the prices into the selected currency but thereafter if a page is loaded or refreshed, the price reverts back to the shop currency.

@NathanPJF
Copy link
Contributor

Sorry to hear you're having trouble, @emmadolan

I'm going to label this one as question and we'll see if there's something going on in Slate that is stripping the HTML wrappers declared in the currency formatting.


Note to contributors:

Verify that any HTML elements added by merchants are kept.

Screenshot from docs.

 

@t-kelly
Copy link
Contributor

t-kelly commented Oct 27, 2017

@emmadolan I'm fairly confident this is not a bug with Slate.

The tutorial you provided is one solution of many for dealing with currencies, something we can never fully predict or guarantee compatibility with when developing Slate. Being a public repo with a growing number of users, we also need to make sure we stay focused on addressing issues about Slate and not theme development in general.

I would recommend getting in touch with a Shopify Expert if you're having trouble debugging your solution.

@t-kelly t-kelly closed this as completed Oct 27, 2017
@sebbean
Copy link

sebbean commented Jul 27, 2018

@t-kelly the show-multiple-currencies workflow is completely broken with the new version of slate

I think updating it or removing it is best to avoid confusion.

Been banging my head against the wall for most the day trying to get that tutorial up and running.

this seems related
#409

it's come down to the code snipped having $ vs jQuery conflicts.

I've had this before with webpack but none of the normal tricks (trying to set window.jQuery = $) seem to work. Still getting jQuery undefined errors.

@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants