Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Add support for Fabric / new architecture #676

Closed
chrfalch opened this issue Jul 8, 2022 · 10 comments · Fixed by #1961
Closed

Android: Add support for Fabric / new architecture #676

chrfalch opened this issue Jul 8, 2022 · 10 comments · Fixed by #1961
Labels

Comments

@chrfalch
Copy link
Contributor

chrfalch commented Jul 8, 2022

See #387

@SVossMcK
Copy link

Has anyone made progress migrating this library to Fabric or can I help in anyway? I'm using version 0.1.158 and it still throws the "unimplemented component" error when rendering a canvas. Unfortunately we have no choice but to use the Fabric architecture and we would really like to use this library but cannot seem to get it working with Fabric. Does anyone have any more information on this topic?

@bryanmehall
Copy link

Are there any updates on this? I just upgraded to Fabric on the new architecture and the the Skia components are breaking on Android. RN 0.71 makes the new architecture upgrade much easier so I imagine that a lot of apps are going to migrate soon.

@LazloN5
Copy link

LazloN5 commented Mar 1, 2023

Any news ? :)

@kibiz0r
Copy link

kibiz0r commented Jul 19, 2023

I haven't seen many people talking about it, but there is an interop layer for the legacy arch now. reactwg/react-native-new-architecture#135

I don't know if it's practical for this lib or not, but if anyone is desperate to get the rest of their project on Fabric while still using Skia, I'd love to hear how it goes.

If it works alright, maybe we could get a "Fabric-compatible" release ahead of real Fabric support?

@kylegillen
Copy link

Totally understand this project has a lot of moving parts and paying supporters get priority, as has been stated already.

Having said that, for teams wanting to adopt the new arch, could a maintainer weigh-in on what a timeline for RN Skia supporting it may be?

Weeks? Months? Years?

Just so we can move forward with using it or not :)
Thanks.

@erie-e9
Copy link

erie-e9 commented Oct 20, 2023

I just tested it with Hermes enabled and using:
-@shopify/react-native-skia v0.1.213
-react v18.2.0
-react-native v0.72.6
For Android built, but getting next error on iOS platform

Captura de pantalla 2023-10-19 a la(s) 10 27 57 p m

Temporal fix, add next to react-native.config.js file:

Captura de pantalla 2023-10-21 a la(s) 3 59 15 p m

Note 1 for temporal fix: Only worked for Android.
Note 2 for temporal fix: You might reinstall app after add fix.

@okaybeydanol
Copy link

I just tested it with Hermes enabled and using: -@shopify/react-native-skia v0.1.213 -react v18.2.0 -react-native v0.72.6 For Android built, but getting next error on iOS platform

Captura de pantalla 2023-10-19 a la(s) 10 27 57 p m

I'm having the same problem, I couldn't find how to solve it. Does anyone know?

@okaybeydanol
Copy link

Can I know if there is any progress on this?

@JuanRdBO
Copy link

JuanRdBO commented Nov 3, 2023

I'd love Skia on the new arch!

@okaybeydanol
Copy link

@wcandillon Thank you, I'm trying it right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants