Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize spacing on the product page #687

Closed
sofiamatulis opened this issue Sep 24, 2021 · 2 comments
Closed

Optimize spacing on the product page #687

sofiamatulis opened this issue Sep 24, 2021 · 2 comments

Comments

@sofiamatulis
Copy link
Contributor

sofiamatulis commented Sep 24, 2021

Describe the current behavior

There is excessive space between blocks on the product page.

Original comment: #655 (review)

Describe the expected behavior

Reduce some of the spacing and check if all scenarios look good

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 1.0.0
  • Chrome Version 91.0.4472.114
  • macOS Version 11.3.1

cc @melissaperreault

@sofiamatulis
Copy link
Contributor Author

sofiamatulis commented Sep 27, 2021

@melissaperreault I just took a quick look at the spacing issue that we were having and I am not sure if it makes sense to decrease it.

The extra spacing right now only shows when the user is on browser and resizes the screen to mobile, which seems like an edge case (or it doesnt allow for 3D models in their device I believe).

The experience looks good on the editor when we have the 3D model: https://screenshot.click/27-29-w9f1g-j2vgb.png (view in your space doesnt show)

It also looks good when there is no 3D model: https://screenshot.click/27-25-otnry-k7j33.png

And in the device it seems to look good too: https://screenshot.click/27-26-o28ou-7v18o.png

What do you think? 🤔

@melissaperreault
Copy link
Contributor

Oh, good news then, let's revisit if this becomes a concern! Thanks for investigating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants