Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering does not take effect when a collection has a tag in its URL #653

Open
MegsParkinson opened this issue Sep 20, 2021 · 6 comments
Open

Comments

@MegsParkinson
Copy link

MegsParkinson commented Sep 20, 2021

Describe the current behavior

When a menu item is a collection with a product tag as a filter, the filter function does not filter the products.
image

[Screenshot removed]

Describe the expected behavior

The filter should filter the products in the collection, even though they have been already filtered by product tag in the navigation menu.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 2.0.0 - 2.1.0
  • Chrome Version 93.0.4577.82
  • macOS Version 11.6

Possible solution
None found

Additional context/screenshots
Was reported previously, issue has been closed but not resolved: #129

@tairli
Copy link
Contributor

tairli commented Sep 20, 2021

I guess, #129 was closed because it's not a theme but backend problem.

@TGIFelix
Copy link

Having the same issue. Did anyone find a fix?

@rcobiella
Copy link

Same here. Any workarounds?

@MegsParkinson
Copy link
Author

MegsParkinson commented Sep 27, 2021

You can create automated collections using the product tags and use those new collections in the menu. This works, so for now I'm using that as a workaround.

@salvodees
Copy link

salvodees commented Jan 24, 2022

Hi @MegsParkinson, I have been investigating this issue and our devs confirmed the issue you are reporting is not exactly the same as this one: #129.

Tag filtering is considered more of a hack and not a scalable/dynamic design choice like the new filtering system is, therefore not seeing the filters on a collection page where a tag has been used as a filter is an expected behaviour and the result of an explicit product decision.

In other words, a merchant can use tags for filtering OR use filters for filtering. They can not be used together.

This has also been documented on this Shopify Doc.

image

On the other hand, what wasn't expected is that the filters showed up in the theme with a tag applied. They should not have been showing up. That's what was fixed in this issue.

I hope this clarifies and if there are no further questions please feel free to close this issue.

@robotshatemonkeys
Copy link

robotshatemonkeys commented Mar 7, 2022

This has SEO implications, that make migration complicated.
Imagine you have one of the following clusters structure ( faceted search )
/collections/brandname/brandtype
/collections/gender/brand

It will be really hard to migrate to the new filtering:

  • restructuring everything, move nested folders to new collections ( increasing exponentially the number of collections to manage )
  • change all the canonical urls.
  • define all the redirects from the old url

I really don't understand why Shopify doesn't allow both solutions to work together.
Faceted search and Filtered search are complementary features.
There are many giant retails applying mixed solutions, including zalando, farfetch and many others, and it's for a reason.
Some filters make sense as crawlable faceted subfolders while others as url queries.

This sounds more like a backend technical issue than a design / business decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants