Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung Internet: Grey box on Product Pages #508

Closed
nicklepine opened this issue Aug 27, 2021 · 3 comments · Fixed by #311
Closed

Samsung Internet: Grey box on Product Pages #508

nicklepine opened this issue Aug 27, 2021 · 3 comments · Fixed by #311
Assignees
Labels
Category: Bug Something isn't working Severity: 1 Urgent Severity

Comments

@nicklepine
Copy link

Describe the current behavior

On Samsung Internet, on Android phones, there is a gray area above the first image of the product details page.
image

image

From @martinamarien:

Seems like the issue is two-fold:

  • the width and height attributes are not working properly on the image element.
  • The padding we use for the image “placeholder” is not behind the image and/or not getting the right height.
@nicklepine nicklepine added Severity: 1 Urgent Severity Category: Bug Something isn't working labels Aug 27, 2021
@kmeleta kmeleta self-assigned this Aug 27, 2021
@silkfab
Copy link

silkfab commented Aug 29, 2021

Hey Ken Meleta,
After the update of the given code,
WhatsApp Image 2021-08-29 at 15 53 25
there is one more issue that still persists in the banner image... that is not responsive.

@silkfab
Copy link

silkfab commented Aug 29, 2021

.media__wrapper > img {
display: block;
max-width: 100%;
height: 100%;
width: 100%;
position: relative;
}

change with
.media__wrapper > img {
display: block;
max-width: 100%;
height: 100%;
width: 100%;
position: absolute;
}

Now Working Fine

@kmeleta kmeleta mentioned this issue Aug 30, 2021
5 tasks
@kmeleta kmeleta linked a pull request Sep 2, 2021 that will close this issue
5 tasks
@kmeleta
Copy link
Contributor

kmeleta commented Sep 2, 2021

The root cause of this issue was found and fixed via #311

@kmeleta kmeleta closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working Severity: 1 Urgent Severity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants