Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove optional chaining #487

Closed
martinamarien opened this issue Aug 25, 2021 · 0 comments · Fixed by #489
Closed

Remove optional chaining #487

martinamarien opened this issue Aug 25, 2021 · 0 comments · Fixed by #489
Assignees
@martinamarien
Labels
Effort: Medium Severity: 1 Urgent Severity

Comments

@martinamarien
Copy link
Contributor

martinamarien commented Aug 25, 2021 •
edited
Loading

Describe the current behavior
Dawn is using optional chaining. This is supported in safari 13.1 and later.

It is causing JS to break and prevents buyers from adding items to their cart and checking out.
Since we officially need to support the latest two versions of safari, this needs to be removed.

Related issue #266

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 1.1.0 (all versions)
  • Safari (versions < 13.1)

Possible solution
Remove optional chaining from Dawn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinamarien martinamarien

Labels
Effort: Medium Severity: 1 Urgent Severity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all instances of optional chaining Shopify/dawn
1 participant
@martinamarien