Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multicolumn] Image alt text defaults to column title #395

Closed
svinkle opened this issue Aug 12, 2021 · 1 comment · Fixed by #405
Closed

[Multicolumn] Image alt text defaults to column title #395

svinkle opened this issue Aug 12, 2021 · 1 comment · Fixed by #405
Assignees
Labels
Category: Accessibility Bugs found while using assistive technology Category: Bug Something isn't working Effort: Low Severity: 1 Urgent Severity

Comments

@svinkle
Copy link
Member

svinkle commented Aug 12, 2021

Issue summary

In the Multicolumn section, if an image is added, its alt text is automatically set from the column title. Depending on the intended purpose of the image/content, this could result in incorrect alt content or missing alt content.

Screenshots Dawn theme multicolumn section. Chrome devtools displays alt text for image logo which matches column title text.

Current code

HTML

<img  alt="Google Test"  />
<h3 >Google Test</h3>

Steps to reproduce

  1. Go to a Dawn homepage which features the Multicolumn section with images with any supported browser
  2. In admin, set the image alt text different than the column title text
  3. Use the web inspector to review the image and heading markup

Behavior

Expected

  • Image alt value to be as set in Admin.

Actual

  • Image alt is set as the column title text.

Recommendation

Separate the image alt text from the column heading text. Use the liquid variable from the image object and set as the image alt attribute value.

Recommended code

HTML

<img  alt="Google"  />
<h3 >Google Test</h3>

Specifications

@svinkle svinkle added Severity: 1 Urgent Severity Category: Bug Something isn't working Category: Accessibility Bugs found while using assistive technology Effort: Low labels Aug 12, 2021
@robertKegel
Copy link
Contributor

Changed the multicolumn.liquid section file to assign block.settings.image.alt to the img tag's alt attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Accessibility Bugs found while using assistive technology Category: Bug Something isn't working Effort: Low Severity: 1 Urgent Severity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants