Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer fast follow-ups #361

Closed
5 tasks
tyleralsbury opened this issue Aug 10, 2021 · 0 comments · Fixed by #369
Closed
5 tasks

Footer fast follow-ups #361

tyleralsbury opened this issue Aug 10, 2021 · 0 comments · Fixed by #369
Assignees
@kmeleta
Labels
Effort: Low Severity: 1 Urgent Severity

Comments

@tyleralsbury
Copy link
Contributor

tyleralsbury commented Aug 10, 2021 •
edited by wiktoriaswiecicka-zz
Loading

I know this was merged, but I'm not sure where else to leave these notes, sorry!

UI polish notes from @wiktoriaswiecicka and I:

  • Can we re-add the separating line between the footer and the section above on mobile
  • "Powered by shopify" should be below the payment icons on mobile. Screenshot | Figma
  • Reduce space between social icon and separator line on mobile. Screenshot.
  • The "Powered by Shopify" text should take the "Mobile caption" text styling on mobile (10px) and "Desktop caption" styling on desktop (12px). Currently it's 12.5 on both.
  • Once "Powered by Shopify" text is moved below payment icons on mobile and desktop, the space between the selectors and the payment icons should reduce to 40px.

Originally posted by @Oliviammarcello in #318 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmeleta kmeleta

Labels
Effort: Low Severity: 1 Urgent Severity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Footer UI updates follow up Shopify/dawn
2 participants
@kmeleta @tyleralsbury