Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick order list: Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation #3201

Open
edmund-teh opened this issue Jan 17, 2024 · 0 comments · Fixed by #3203

Comments

@edmund-teh
Copy link

edmund-teh commented Jan 17, 2024

When a buyer is using the Quick order list and clicking Remove all with only 1 item in cart, the confirmation messaging should say, Remove 1 item from cart? instead of Remove all 1 items from your cart?.

This may need further assistance with translations too.

cc: @sofiamatulis, @eugenekasimov, @nicklepine

@melissaperreault's screenshot of the old string here: https://screenshot.click/08-53-yegxl-npeta.png

Steps to reproduce:

  1. When interacting with the Quick Order list section and you've added 1 item to cart, Total items = 1
  2. Click 🗑️ Remove all
  3. The confirmation messaging says Remove all 1 items from your cart?, which is wrong
  4. For this singular case only, it should read Remove 1 item from cart?
  5. For all other cases, it should read Remove all # items from your cart?

@katycobb helped with a quick pass of the copy.

Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant