Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announcement bar's preview inspector outline is visible on hidden slides #2612

Closed
melissaperreault opened this issue May 4, 2023 · 3 comments
Assignees
Labels
Category: Bug Something isn't working good first issue

Comments

@melissaperreault
Copy link
Contributor

melissaperreault commented May 4, 2023

Describe the current behavior

Other slides that are not in view, their outline shouldn’t be visible, even more if they are not clickable. Video reference

Describe the expected behavior

Inspector outline should only be visible on the active slide.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 9.0.0
  • Chrome Version 108.0.5359.124
  • macOS Version 13.1
@melissaperreault melissaperreault added the Category: Bug Something isn't working label May 4, 2023
@eugenekasimov
Copy link
Contributor

eugenekasimov commented May 4, 2023

I'm not sure for 100% but it seems that we cannot avoid this issue if we wanna keep the inspector on slides and not only on the whole announcement bar section 🤔

The only way I can see to fix this is to apply the inspector on the announcement bar itself.

@ludoboludo am I right?

@eugenekasimov eugenekasimov self-assigned this May 15, 2023
@eugenekasimov
Copy link
Contributor

Okay, the solution was found. I'm about to create a PR.

@kimberlyoleiro
Copy link

@eugenekasimov this issue got fixed last wee #2810

This is the counterpart PR in online-store-web to update the preview inspector https://github.com/Shopify/online-store-web/pull/17287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants