Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding the variant picker on Product Page breaks Quick Add #2048

Closed
LucasLacerdaUX opened this issue Oct 18, 2022 · 0 comments · Fixed by #2049
Closed

Hiding the variant picker on Product Page breaks Quick Add #2048

LucasLacerdaUX opened this issue Oct 18, 2022 · 0 comments · Fixed by #2049

Comments

@LucasLacerdaUX
Copy link
Contributor

Describe the current behavior
If a merchant hides the variant picker on the product page, the Choose options Quick Add button will not work.

Describe the expected behavior
It should not be required for quick add modals to have a variant picker.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 7.0.0

Possible solution
Check if the variant-radios and variant-selects exist before updating it.

Additional context/screenshots
Caused by this line:

    preventVariantURLSwitching() {
      this.modalContent.querySelector('variant-radios,variant-selects').setAttribute('data-update-url', 'false');
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant