We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the current behavior If a merchant hides the variant picker on the product page, the Choose options Quick Add button will not work.
Choose options
Describe the expected behavior It should not be required for quick add modals to have a variant picker.
Version information (Dawn, browsers and operating systems)
Possible solution Check if the variant-radios and variant-selects exist before updating it.
variant-radios
variant-selects
Additional context/screenshots Caused by this line:
preventVariantURLSwitching() { this.modalContent.querySelector('variant-radios,variant-selects').setAttribute('data-update-url', 'false'); }
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Describe the current behavior
If a merchant hides the variant picker on the product page, the
Choose options
Quick Add button will not work.Describe the expected behavior
It should not be required for quick add modals to have a variant picker.
Version information (Dawn, browsers and operating systems)
Possible solution
Check if the
variant-radios
andvariant-selects
exist before updating it.Additional context/screenshots
Caused by this line:
The text was updated successfully, but these errors were encountered: