Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Media size setting] Change thumbnail media fit to "fill" #2047

Closed
duygukalaycioglu opened this issue Oct 18, 2022 · 0 comments · Fixed by #2044
Closed

[Media size setting] Change thumbnail media fit to "fill" #2047

duygukalaycioglu opened this issue Oct 18, 2022 · 0 comments · Fixed by #2044
Assignees
@kmeleta @duygukalaycioglu

Comments

@duygukalaycioglu
Copy link

duygukalaycioglu commented Oct 18, 2022 •
edited
Loading

PR SUMMARY
This ticket is a branch of media fit ticket. Issue: 2016

Update on thumbnails: The thumbnails will always be set to media fit "fill" on desktop and mobile - no matter the media fit option or asset type the merchant selects for desktop.
@duygukalaycioglu duygukalaycioglu changed the title [Media size setting] Change thumbnail media fit to cover by default [Media size setting] Change thumbnail media fit to fill Oct 18, 2022
@kmeleta kmeleta mentioned this issue Oct 18, 2022
Merged
8 tasks
@duygukalaycioglu duygukalaycioglu changed the title [Media size setting] Change thumbnail media fit to fill [Media size setting] Change thumbnail media fit to "fill" Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmeleta kmeleta

@duygukalaycioglu duygukalaycioglu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change thumbnail media fit to "fill" by default Shopify/dawn
2 participants
@kmeleta @duygukalaycioglu