-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit UI for Filters & Behavior #198
Comments
Technical input... Collapsing automatically when the filters wrap would not be easy, so a better avenue would be something like either:
For the collapsed version, the easiest approach would be to effectively use the mobile filters for all viewports, with the swing-out panel from the right side. |
Based on the feedback received we have decided to add these improvements:
For all edge cases like filter wrapping and spacing details the figma file can be found here. |
If our rationale for implementing a custom select is purely for aesthetic reasons, IMO it is in the buyer's best interest to keep the browser's native If we were to replace the browser's native
Even if all a11y functionality is recreated, we have to take into account that native Usability tests comparing custom selects to native
Alternatively, we could use an approach which allows mouse users to interact with a custom select, while allowing keyboard and mobile users to interact with a native |
**UI **
Potential solution
-Revisit the current behaviour to potentially add a setting for presentation: list out all filters vs collapse
The text was updated successfully, but these errors were encountered: