Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quick add] Button visible with no-JS #1633

Closed
andrewetchen opened this issue Apr 19, 2022 · 0 comments · Fixed by #1904
Closed

[Quick add] Button visible with no-JS #1633

andrewetchen opened this issue Apr 19, 2022 · 0 comments · Fixed by #1904
Assignees
Labels
Category: Bug Something isn't working

Comments

@andrewetchen
Copy link
Contributor

andrewetchen commented Apr 19, 2022

Describe the current behavior

Quick add button still visible when JavaScript is disabled.

Describe the expected behavior

For quick add to not be visible when JavaScript is disabled.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 5.0.0
  • Chrome Version: 100.0.4896.127
  • macOS Version: 12.3.1

Possible solution

Add the no-js-hidden class to the following:

<div class="quick-add">

Solution - Collection page

image

Solution - Featured collection section

image


Additional context/screenshots

Collection page

Featured collection

  • Navigate to any Featured collection section.
  • Enable the Enable quick add button setting.
  • Click save.
  • Preview the storefront and navigate to the Featured collection section.
  • Disable JavaScript.
  • Reload the page.

@andrewetchen andrewetchen added the Category: Bug Something isn't working label Apr 19, 2022
@KaichenWang KaichenWang self-assigned this Jul 21, 2022
@metamoni metamoni self-assigned this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants