Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slider to multicolumn section on tablet #1397

Open
sofiamatulis opened this issue Feb 23, 2022 · 2 comments
Open

Add slider to multicolumn section on tablet #1397

sofiamatulis opened this issue Feb 23, 2022 · 2 comments

Comments

@sofiamatulis
Copy link
Contributor

sofiamatulis commented Feb 23, 2022

Describe the enhancement you'd like
Currently all sections that have enable slider on mobile setting affect mobile and tablet. Except for multicolumn. It only affects mobile.

When we are using the label mobile , we are affecting mobile and tablet. However I did notice that multicolumn only has the slider ("enable slider on mobile" setting) on mobile and not on tablet.

This can be confusing for merchants since everywhere else mobile affects tablet as well except for here. In addition to that, using the label mobile would be confusing if not consistent across the sections. Original comment: #1352 (comment)

Describe alternatives you've considered
Keep it this way and add a helper text?

cc @katycobb @wiktoriaswiecicka

@sofiamatulis
Copy link
Contributor Author

Related: original comment by @ludoboludo

When enabling the slider, there is a change in spacing on tablet that is happening. I'm not sure if we want to actually fix it or wait until we add the slider on tablet 🤔
video

@melissaperreault
Copy link
Contributor

Related issue comment: #1360 (comment)

I wonder here if we should be adding the slider on tablet as well. It took me a few seconds to realize that it's a section on which Enable swipe on mobile means only on mobile but not on tablet. When others, like feat. collection, blog posts do.

Could be a follow up but I think should be shipped in the same them update/upgrade. Otherwise it makes for an odd experience. But maybe it would have too much of an impact on existing merchants. Unless we have a breaking change included and then we don't need to worry about it

#1352 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants