Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Email signup] Non full-width missing bottom margin #1125

Open
svinkle opened this issue Jan 7, 2022 · 1 comment
Open

[Email signup] Non full-width missing bottom margin #1125

svinkle opened this issue Jan 7, 2022 · 1 comment
Labels
Category: Bug Something isn't working

Comments

@svinkle
Copy link
Member

svinkle commented Jan 7, 2022 •
edited
Loading

Describe the current behavior
For the Email signup section, toggling Make section full width off seems to remove all bottom margin.

Describe the expected behavior
I assume there'd be some margin here to add space?

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 2.5.0
  • Firefox 95 (any browser)
  • macOS Version 12.1

Possible solution

Additional context/screenshots
Email signup section sits directly against footer section without any spacing in between.
@svinkle svinkle added the Category: Bug Something isn't working label Jan 7, 2022
@nicklepine
Copy link

This will be fixed with #1110 we're adding a margin setting for the footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svinkle @nicklepine