Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padding settings follow-up #1039

Closed
tyleralsbury opened this issue Dec 17, 2021 · 3 comments · Fixed by #1110
Closed

Padding settings follow-up #1039

tyleralsbury opened this issue Dec 17, 2021 · 3 comments · Fixed by #1110
Assignees
@tyleralsbury
Labels
global settings Severity: 1 Urgent Severity

Comments

@tyleralsbury
Copy link
Contributor

tyleralsbury commented Dec 17, 2021 •
edited
Loading

Some other sections may also benefit from this setting

Collection template - Product grid section

Screen_Shot_2021-12-17_at_2_01_34_PM

Blog template - Blog posts section

Screen_Shot_2021-12-17_at_2_09_56_PM

Search template - Search results section

Screen_Shot_2021-12-17_at_2_09_07_PM

Not a section, but could still use some padding

Blog post template - Blog post section

Screen_Shot_2021-12-17_at_2_04_40_PM

Originally posted by @KaichenWang in #1006 (review)
@tyleralsbury tyleralsbury added the Severity: 2 High Severity label Dec 17, 2021
@KaichenWang
Copy link
Contributor

KaichenWang commented Dec 20, 2021 •
edited
Loading

Update on the values for the sliders:

  • When set to under 24 it will be a 1:1 relationship
  • When set to 24 or over, mobile will be 0.7 times the value. There will be a 20px minimum which will be needed specifically when set to 24.

#1006 (comment)

@KaichenWang
Copy link
Contributor

KaichenWang commented Dec 20, 2021 •
edited
Loading

#1000 (comment)

@melissaperreault melissaperreault mentioned this issue Dec 21, 2021
Merged
5 tasks
@nicklepine nicklepine added Severity: 1 Urgent Severity and removed Severity: 2 High Severity labels Jan 4, 2022
@tyleralsbury tyleralsbury self-assigned this Jan 5, 2022
@nicklepine nicklepine mentioned this issue Jan 6, 2022
Closed
@tyleralsbury
Copy link
Contributor Author

Header

  • Add a bottom margin setting to allow spacing between the header and the first section on the page

Footer

  • Add a top margin setting - same as header
  • Add top and bottom padding settings like other sections

@tyleralsbury tyleralsbury mentioned this issue Jan 6, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyleralsbury tyleralsbury

Labels
global settings Severity: 1 Urgent Severity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Additional padding and margin settings Shopify/dawn
3 participants
@KaichenWang @nicklepine @tyleralsbury