-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shopify asset_url filter not working on local and resolves to /assets instead on the shopify CDN leading to 404s #2096
Comments
@evilzebra-labs Thanks for letting me know this isn't isolated or some environment issue, i've actually had this problem for a month or so as well but it wasn't a priority until now. |
@merziy no worries... I checked the latest bug reports... and it looks like a lot of people are facing the same issue... The weird thing is it happens only in some stores, and others work just fine. And the same is happening to me.. it wasn't a BIG priority until now... |
Same issue here. Rolling back to previous CLI versions has not solved the issue either. This is impacting one store, with a now impatient client. |
Thank you, everyone, for reporting this and sharing those details. The issue has been resolved through #2105 and will be included in the next release of the CLI. |
CLI version 3.46.3 has been released, including the fix. Thanks @karreiro for making it happen. Folks, please update to the latest and let us know if you continue to encounter any issues. Thanks as always for your input! |
@amcaplan I have updated my CLI to the last version 3.47.2 and error is still happening :( |
FYI @karreiro ⬆️ |
@EricMainhard, this issue shouldn't happen on 3.47.2 indeed, could you please follow the steps below to help us better understand the scenario you're facing?
With that information we can gain more context regarding the issue you're facing and fix it. Thank you for reporting that! |
This is still happening on 3.49.7. Unfortunately this bug makes doing theme development impossible on the platform. Given history and experience I think we can all just expect this to be a problem forever. Enjoy your jobs, everyone. |
Please confirm that you have:
In which of these areas are you experiencing a problem?
Function, Theme, Other
Expected behavior
Files with the
asset_url
filter using Shopify CLI version 3.46.2 should resolve over the Shopify CDNActual behavior
Files with the
asset_url
filter using Shopify CLI version 3.46.2 on two different projects, but not all, are resolving as{myshopifysite}.myshopify.com/assets/{asset-name}.css?v=139638057495805369281685991684
, which leads to 404s in the console, instead of being delivered over the CDN as something like{myshopifysite}.myshopify.com/cdn/shop/files/{asset-name}
.Verbose output
Reproduction steps
{myshopifysite}.myshopify.com/assets/{asset-name}
instead of{myshopifysite}.myshopify.com/cdn/shop/files/{asset-name}
Operating System
Mac OS 13.4 (22F66)
Shopify CLI version (check your project's
package.json
if you're not sure)3.46.2
Shell
zsh
Node version (run
node -v
if you're not sure)v20.2.0
What language and version are you using in your application?
Liquid, Javascript
The text was updated successfully, but these errors were encountered: