Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.x version_compare error #128

Closed
Thiiil opened this issue Feb 3, 2021 · 1 comment
Closed

PHP 8.x version_compare error #128

Thiiil opened this issue Feb 3, 2021 · 1 comment

Comments

@Thiiil
Copy link

Thiiil commented Feb 3, 2021

As described in https://bugs.php.net/bug.php?id=80503

PHP 8 doesn't support "gte' operator for version_compare()

I have found this one triggered only in fpm mode which break several things like Zend_Currency

zf1-future/library/Zend/Xml/Security.php

Line 172 in c84dedf

version_compare(PHP_VERSION, '5.6', 'gte')

It's an easy fix, I submit this case for memory / info.

hav a nice day.
This was referenced Feb 3, 2021
Closed
Merged
@glensc
Copy link
Collaborator

glensc commented Feb 5, 2021

the line you point to is fixed in zf1s project, included in 1.13.4 release:

Shardj pushed a commit that referenced this issue Feb 6, 2021
fixes issue #128
d472c35
@Shardj Shardj closed this as completed Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Thiiil @glensc @Shardj