Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming: PodcastReleaseDate #328

Closed
uklotzde opened this issue Jan 5, 2024 · 1 comment · Fixed by #329
Closed

Naming: PodcastReleaseDate #328

uklotzde opened this issue Jan 5, 2024 · 1 comment · Fixed by #329
Labels
enhancement New feature or request

Comments

@uklotzde
Copy link
Contributor

uklotzde commented Jan 5, 2024 •
edited
Loading

Summary

The corresponding file tags are not restricted to podcasts. Why is the item named PodcastReleaseDate instead of just ReleaseDate? The specific use case for tagging podcast episodes should only be mentioned in the docs.

Since this item was only used for MP3 files until v0.17.1 renaming it now before extending the support for more file types might be the last chance without causing too much trouble and confusion.

API design

Rename PodcastReleaseDate to ReleaseDate and document the use case for podcast episodes as one example.
@uklotzde uklotzde added the enhancement New feature or request label Jan 5, 2024
@uklotzde
Copy link
Contributor Author

uklotzde commented Jan 5, 2024

Related: #327

Maybe a good opportunity to change multiple namings at once.

@uklotzde uklotzde mentioned this issue Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename PodcastReleaseDate to ReleaseDate uklotzde/lofty-rs
1 participant
@uklotzde