Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal continuously updating #969

Closed
flipvrijn opened this issue Dec 1, 2016 · 1 comment · Fixed by #973
Closed

Modal continuously updating #969

flipvrijn opened this issue Dec 1, 2016 · 1 comment · Fixed by #973

Comments

@flipvrijn
Copy link
Contributor

Whenever a modal is open and you check the updates being done by React, the modal is being updated constantly even when doing nothing. I don't know if this is intended or not, but I imagine it puts strain on the rendering.

Steps

  1. Go to: http://react.semantic-ui.com/modules/modal
  2. Click on a modal button
  3. Enable Trace React Updates in the React tab of the Web Developer Console.
  4. ...

Expected Result

No continuous updating of the modal

Actual Result

Continuously updating the modal as shown here:
Continuously updating modal

Version

Checked versions 0.61.7 and 0.61.8.
@flipvrijn flipvrijn changed the title Modal infinite update loop Modal continuous update loop Dec 1, 2016
@flipvrijn flipvrijn changed the title Modal continuous update loop Modal continuously updating Dec 1, 2016
@jeffcarbs jeffcarbs mentioned this issue Dec 1, 2016
Merged
@jeffcarbs
Copy link
Member

Nice catch! Just opened a PR to fix it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Modal): prevent unnecessary renders Semantic-Org/Semantic-UI-React
2 participants
@flipvrijn @jeffcarbs