Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance test for children/description/text props #71

Closed
levithomason opened this issue Oct 20, 2015 · 1 comment
Closed

Conformance test for children/description/text props #71

levithomason opened this issue Oct 20, 2015 · 1 comment

Comments

@levithomason
Copy link
Member

Some components will take a description or text prop. These props may also be defined using children.

In the case where children and another conflicting prop is defined, the children prop should win. We should be able to test if the current component is a Semantic component (see #70), and if it has a description/test prop, then test that the children prop wins if both are defined.
This was referenced Oct 20, 2015
Merged
Closed
@levithomason
Copy link
Member Author

Done and implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@levithomason