From cfcc455713af9ad904c730bccc62be8726814270 Mon Sep 17 00:00:00 2001
From: titusfortner <titusfortner@gmail.com>
Date: Fri, 27 May 2022 01:46:26 -0500
Subject: [PATCH] fix failing tests

---
 py/selenium/webdriver/common/actions/mouse_button.py   |  1 -
 rb/CHANGES                                             |  1 +
 .../selenium/webdriver/action_builder_spec.rb          |  3 ++-
 rb/spec/integration/selenium/webdriver/element_spec.rb | 10 +++++-----
 .../webdriver/spec_support/test_environment.rb         |  2 +-
 5 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/py/selenium/webdriver/common/actions/mouse_button.py b/py/selenium/webdriver/common/actions/mouse_button.py
index b0fa713312e38..1ebd28ff1ba53 100644
--- a/py/selenium/webdriver/common/actions/mouse_button.py
+++ b/py/selenium/webdriver/common/actions/mouse_button.py
@@ -23,4 +23,3 @@ class MouseButton:
     RIGHT = 2
     BACK = 3
     FORWARD = 4
-
diff --git a/rb/CHANGES b/rb/CHANGES
index cd0ee91601753..346a02591eb4d 100644
--- a/rb/CHANGES
+++ b/rb/CHANGES
@@ -41,6 +41,7 @@ ActionBuilder:
   * Add support for pointer event properties
   * Implement scroll wheel support
   * Deprecate ordered pair parameters for pause method in favor of keywords
+  * Deprecate move to element with offset changing origin to top left of element
 
 4.1.0 (2021-11-22)
 =========================
diff --git a/rb/spec/integration/selenium/webdriver/action_builder_spec.rb b/rb/spec/integration/selenium/webdriver/action_builder_spec.rb
index 727409d18a33c..ce966df9b5dc9 100644
--- a/rb/spec/integration/selenium/webdriver/action_builder_spec.rb
+++ b/rb/spec/integration/selenium/webdriver/action_builder_spec.rb
@@ -260,7 +260,7 @@ module WebDriver
         end
       end
 
-      describe 'pen stylus' do
+      describe 'pen stylus', except: {browser: :firefox, reason: 'Unknown pointerType'} do
         it 'sets pointer event properties' do
           driver.get 'https://titusfortner.com/examples/pointerActionsPage.html'
           pointer_area = driver.find_element(id: 'pointerArea')
@@ -374,6 +374,7 @@ module WebDriver
           iframe = driver.find_element(tag_name: 'iframe')
           driver.switch_to.frame(iframe)
           checkbox = driver.find_element(name: 'scroll_checkbox')
+          sleep 0.5
           expect(in_viewport?(checkbox)).to eq true
         end
 
diff --git a/rb/spec/integration/selenium/webdriver/element_spec.rb b/rb/spec/integration/selenium/webdriver/element_spec.rb
index 4145465a87956..2101646137cb9 100644
--- a/rb/spec/integration/selenium/webdriver/element_spec.rb
+++ b/rb/spec/integration/selenium/webdriver/element_spec.rb
@@ -45,7 +45,7 @@ module WebDriver
           driver.navigate.to url_for('formPage.html')
           driver.find_element(id: 'submitButton').submit
 
-          wait_for_new_url('formPage.html')
+          sleep 0.5
           expect(driver.title).to eq('We Arrive Here')
         end
 
@@ -53,7 +53,7 @@ module WebDriver
           driver.navigate.to url_for('formPage.html')
           driver.find_element(id: 'checky').submit
 
-          wait_for_new_url('formPage.html')
+          sleep 0.5
           expect(driver.title).to eq('We Arrive Here')
         end
 
@@ -61,7 +61,7 @@ module WebDriver
           driver.navigate.to url_for('formPage.html')
           driver.find_element(css: 'form > p').submit
 
-          wait_for_new_url('formPage.html')
+          sleep 0.5
           expect(driver.title).to eq('We Arrive Here')
         end
 
@@ -69,7 +69,7 @@ module WebDriver
           driver.navigate.to url_for('formPage.html')
           driver.find_element(id: 'submit').submit
 
-          wait_for_new_url('formPage.html')
+          sleep 0.5
           expect(driver.title).to eq('We Arrive Here')
         end
 
@@ -77,7 +77,7 @@ module WebDriver
           driver.navigate.to url_for('formPage.html')
           driver.find_element(name: 'submit').submit
 
-          wait_for_new_url('formPage.html')
+          sleep 0.5
           expect(driver.title).to eq('We Arrive Here')
         end
 
diff --git a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
index dec712ae91379..0dbfba7d43d6c 100644
--- a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
+++ b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
@@ -29,7 +29,7 @@ def initialize
 
           extract_browser_from_bazel_target_name
 
-          @driver = ENV.fetch('WD_SPEC_DRIVER', :chrome).to_sym
+          @driver = ENV.fetch('WD_SPEC_DRIVER', :firefox).to_sym
           @driver_instance = nil
         end