Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve advertisepipe's error handling #143

Open
aaaaalbert opened this issue Jun 4, 2014 · 0 comments
Open

Improve advertisepipe's error handling #143

aaaaalbert opened this issue Jun 4, 2014 · 0 comments
Labels

Comments

@aaaaalbert
Copy link
Contributor

There are two places currently where an exception can render advertisepipe non-functional but don't let it appear crashed: 1, 2. In both cases the advertise library which is called may raise AdvertiseErrors and TimeoutErrors (mostly when the node is currently disconnected from the network, or the advertise services are under high load).

Both cases need to be fenced by try/except. If an exception is encountered, it's probably best to just retry after a short pause. The advertise thread must never crash.

@aaaaalbert aaaaalbert added the bug label Jun 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant