Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vesselinfo appears missing from installers #1393

Open
choksi81 opened this issue May 25, 2014 · 2 comments
Open

vesselinfo appears missing from installers #1393

choksi81 opened this issue May 25, 2014 · 2 comments

Comments

@choksi81
Copy link

Over the last five years, we have seen a handful of reports claiming that the vesselinfo file is missing from the installer tarball. Upon closer inspection, the file is actually there, but it has an extra ./ prefixed to its path which the other files in the tarball don't have. (Note that this is true for ''all'' of our installer tarballs, not specific to the troublesome ones!)

seattle/seattle_repy/deserialize.repy
seattle/seattle_repy/math.repy
seattle/seattle_repy/servicelookup.repy
# etc., etc.
./seattle/seattle_repy/
./seattle/seattle_repy/vesselinfo 

This prefix is probably the cause of the problem. The prefix comes into existence like this (see wiki:InstallerWorkflow for additional details): The custom installer builder packager takes the base installer tar file and appends the vesselinfo file to it. The directory (and thus file) appended to the archive is defined in line 95 to be, variables expanded, ./seattle/seattle_repy.

Removing the trailing ./ from the directory string (see patch below) also removes it from the directory name as seen in the tar file:

seattle/seattle_repy/deserialize.repy
seattle/seattle_repy/math.repy
seattle/seattle_repy/servicelookup.repy
# etc.
seattle/seattle_repy/
seattle/seattle_repy/vesselinfo

I will ask the most recent reporter of this bug to try an installer tarball built using the new method and see if that fixes the problem.

@choksi81 choksi81 self-assigned this May 25, 2014
@choksi81
Copy link
Author

ubuntu-1304-archive-manager

@choksi81
Copy link
Author

Line     
1   95c95
2   <   config_dir_rel = constants.TEMP_DIR_NAMES['config']
3   ---
4   >   config_dir_rel = os.path.join('.', constants.TEMP_DIR_NAMES['config'])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant