Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate #register*Callback: methods #337

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 3 comments
Closed

Deprecate #register*Callback: methods #337

GoogleCodeExporter opened this issue Mar 25, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Currently there about about 10 #renderSomethingCallback: methods on
WACallbackRegistry, each of which simply calls "self storeCallback:" with
an instance of the appropriate class.

Excluding tests of WACallbackRegistry itself, *every* sender of these
methods is of the form "aCanvas callbacks registerSomethingCallback".

Additionally, almost every sender of #callbacks is of the form "aCanvas
callbacks registerSomethingCallback".

Since all Renderers have a RenderContext and all RenderContexts have a
CallbackRegistry, I suggest we move these methods onto WARenderer. This
will eliminate having to send #callbacks everywhere and mean that Renderers
have the opportunity to override the type of callback that is registered
(there is currently no easy way to specify that a subclass of
WACallbackRegistry be used).

Existing implementations could possibly be left as "deprecated" if desired,
though they would have to duplicate the implementation.

Original issue reported on code.google.com by jfitz...@gmail.com on 6 Feb 2009 at 2:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant