Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#inNewRenderLoopCall: broken with partial continuations #310

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 6 comments
Closed

#inNewRenderLoopCall: broken with partial continuations #310

GoogleCodeExporter opened this issue Mar 25, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

The current implementation of #inNewRenderLoopCall: does not work with
partial continuations. It worked with the full continuations because of a
fluke when the wrong context chain was unwound.

The method should restore the root component when the continuation is
evaluated. The problem is that there is currently no way to get at the
current root component (nor at the current continuation, which holds it). 

This also affects #inNewRenderLoopShow: - #answer does not work for
components displayed this way. I think it might be possible to fix that
once the other issue is fixable.

The most "correct" fix for this, in my opinion, is to store the root
component in the session and backtrack it. The problem is, this really
wants a WARenderLoopSession subclass because the base Session know nothing
about Components. This is only a problem because people are used to
subclassing WASession...

Other possible solutions...
 * SessionContinuations could be made into RequestHandlers (we'd have to
split it into WARequestHandler and WAFilteredRequestHandler) and added to
the context
 * The SessionContinuation could store the root component in the property
dictionary on RequestContext
 * Dunno, other thoughts?

Original issue reported on code.google.com by jfitz...@gmail.com on 27 Jan 2009 at 11:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant