Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPharoCodecTest>>testLanguageTag broken in Pharo 9 #114

Closed
jbrichau opened this issue Dec 20, 2020 · 0 comments
Closed

GRPharoCodecTest>>testLanguageTag broken in Pharo 9 #114

jbrichau opened this issue Dec 20, 2020 · 0 comments

Comments

@jbrichau
Copy link
Member

This change in Pharo 9 breaks the GRPharoCodecTest>>testLanguageTag test.

pharo-project/pharo@202cd0d

The commit in Pharo mentions that it deprecates leadingChar and the old encoders, but actually because of the change in Character>>asUnicode, it breaks the encoding where a leadingChar is used.

I'm not sure what needs to happen but recording this here for now.
@jbrichau jbrichau changed the title GRPharoCodecTest>>testLanguageTag broken GRPharoCodecTest>>testLanguageTag broken in Pharo 9 Dec 20, 2020
This was referenced Dec 25, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbrichau